Skip to content

Pretty print generator witness only in -Zverbose mode #86240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2021
Merged

Pretty print generator witness only in -Zverbose mode #86240

merged 1 commit into from
Jun 12, 2021

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Jun 12, 2021 •
edited
Loading

In release build of deeply-nested-async benchmark the size of
no-opt.bc file is reduced from 46MB to 62kB.

Helps with #84873, where in one of reported test cases the size of no-opt.bc
file is reduced from 2.3GB to 799kB.

@rust-highfive
Copy link
Contributor

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 12, 2021
@tmiasko tmiasko force-pushed the verbose-generator-witness branch from 0bef4cd to 78b981f Compare June 12, 2021 08:09
@tmiasko
Copy link
Contributor Author

tmiasko commented Jun 12, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 12, 2021
@bors
Copy link
Collaborator

bors commented Jun 12, 2021

⌛ Trying commit 78b981fe115633ab7214445101473349cbdfc3ab with merge 3475950431a8883d7ca11420c9954459c70a0b95...

@bors
Copy link
Collaborator

bors commented Jun 12, 2021

☀️ Try build successful - checks-actions
Build commit: 3475950431a8883d7ca11420c9954459c70a0b95 (3475950431a8883d7ca11420c9954459c70a0b95)

@rust-timer
Copy link
Collaborator

Queued 3475950431a8883d7ca11420c9954459c70a0b95 with parent b84ffce, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (3475950431a8883d7ca11420c9954459c70a0b95): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 12, 2021
@jackh726
Copy link
Member

r? @jackh726
@bors r+

@bors
Copy link
Collaborator

bors commented Jun 12, 2021

📌 Commit 78b981fe115633ab7214445101473349cbdfc3ab has been approved by jackh726

@rust-highfive rust-highfive assigned jackh726 and unassigned estebank Jun 12, 2021
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2021
@bors
Copy link
Collaborator

bors commented Jun 12, 2021

⌛ Testing commit 78b981fe115633ab7214445101473349cbdfc3ab with merge 1a3665a8aa94e4c017cb09ac7292dffb843a9469...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Jun 12, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 12, 2021
@tmiasko
Pretty print generator witness only in -Zverbose mode
06ca736 
In release build of deeply-nested-async benchmark the size of
`no-opt.bc` file is reduced from 46MB to 62kB.
@tmiasko tmiasko force-pushed the verbose-generator-witness branch from 78b981f to 06ca736 Compare June 12, 2021 16:33
@tmiasko
Copy link
Contributor Author

tmiasko commented Jun 12, 2021

Rebased and updated output of a test case added in #86215.

@jackh726
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 12, 2021

📌 Commit 06ca736 has been approved by jackh726

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2021
@bors
Copy link
Collaborator

bors commented Jun 12, 2021

⌛ Testing commit 06ca736 with merge 24bdc6d...

@bors
Copy link
Collaborator

bors commented Jun 12, 2021

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 24bdc6d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 12, 2021
@bors bors merged commit 24bdc6d into rust-lang:master Jun 12, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jun 12, 2021
@tmiasko tmiasko deleted the verbose-generator-witness branch June 13, 2021 05:46
@audunska
Copy link

audunska commented Aug 6, 2021

This PR seems to have fixed my exponential compile times issue mentioned in #84873! 🎉

That is, compile times return to normal between nightly 2021-06-12 and 2021-06-13.

@audunska audunska mentioned this pull request Aug 6, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jackh726 jackh726

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.
9 participants
@tmiasko @rust-highfive @rust-timer @bors @jackh726 @rust-log-analyzer @audunska @estebank @rustbot